-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Workflow to generate and push language reference documentation #14852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow to generate and push language reference documentation #14852
Conversation
- name: Cache Coursier | ||
uses: actions/cache@v1 | ||
with: | ||
path: ~/.cache/coursier | ||
key: sbt-coursier-cache | ||
|
||
- name: Cache SBT | ||
uses: actions/cache@v1 | ||
with: | ||
path: ~/.sbt | ||
key: sbt-${{ hashFiles('**/build.sbt') }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think these could and should be replaced with https://github.com/coursier/cache-action?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is copy-paste from our CI. Perhaps we can make it better
key: sbt-${{ hashFiles('**/build.sbt') }} | ||
|
||
- name: Set up JDK 11 | ||
uses: actions/setup-java@v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest release is currently 3.x, should we use a more recent one?
ec3d161
to
3d9ce97
Compare
3d9ce97
to
b332d62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can merge it now and try it. Eventually, it would be good to address the pending comments, though.
This PR is a part of the effort to push the language reference documentation to docs.scala-lang.org. I work on it together with @julienrf .
https://docs.google.com/document/d/1wpvyu_4PH-dqqPoFDbfTjW71bCFFFMYEC8ka_zH8zE8/edit?usp=sharing