Improve documentation and error messages for safe initialization

compiler/src/dotty/tools/dotc/transform/init/Errors.scala

@@ -82,11 +82,11 @@ object Errors:
 
   case class AccessCold(field: Symbol, trace: Seq[Tree]) extends Error:
     def show(using Context): String =
-      "Access field on a value with an unknown initialization status." + stacktrace()
+      "Access field " + field.show +  " on a cold object." + stacktrace()
 
   case class CallCold(meth: Symbol, trace: Seq[Tree]) extends Error:
     def show(using Context): String =
-      "Call method on a value with an unknown initialization." + stacktrace()
+      "Call method " + meth.show + " on a cold object." + stacktrace()
 
   case class CallUnknown(meth: Symbol, trace: Seq[Tree]) extends Error:
     def show(using Context): String =

compiler/src/dotty/tools/dotc/transform/init/Semantic.scala

@@ -56,7 +56,8 @@ object Semantic:
       case ThisRef(klass) =>
         "ThisRef[" + klass.show + "]"
       case Warm(klass, outer, ctor, args) =>
-        "Warm[" + klass.show + "] { outer = " + outer.show + ", args = " + args.map(_.show).mkString("(", ", ", ")") + " }"
+        val argsText = if args.nonEmpty then ", args = " + args.map(_.show).mkString("(", ", ", ")") else ""
+        "Warm[" + klass.show + "] { outer = " + outer.show + argsText + " }"
       case Fun(expr, thisV, klass) =>
         "Fun { this = " + thisV.show + ", owner = " + klass.show + " }"
       case RefSet(values) =>
@@ -1080,7 +1081,7 @@ object Semantic:
                 eval(body, thisV, klass)
               }
               given Trace = Trace.empty.add(body)
-              res.promote("The function return value is not fully initialized.")
+              res.promote("The function return value is not fully initialized. Found = " + res.show + ". ")
             }
             if errors.nonEmpty then
               reporter.report(UnsafePromotion(msg, trace.toVector, errors.head))
@@ -1124,12 +1125,12 @@ object Semantic:
                 withTrace(Trace.empty) {
                   val args = member.info.paramInfoss.flatten.map(_ => ArgInfo(Hot, Trace.empty))
                   val res = warm.call(member, args, receiver = NoType, superType = NoType)
-                  res.promote("Cannot prove that the return value of " + member + " is fully initialized.")
+                  res.promote("Cannot prove that the return value of " + member.show + " is fully initialized. Found = " + res.show + ". ")
                 }
               else
                 withTrace(Trace.empty) {
                   val res = warm.select(member)
-                  res.promote("Cannot prove that the field " + member + " is fully initialized.")
+                  res.promote("Cannot prove that the field " + member.show + " is fully initialized. Found = " + res.show + ". ")
                 }
           end for
         end for
@@ -1230,7 +1231,7 @@ object Semantic:
   /** Utility definition used for better error-reporting of argument errors */
   case class ArgInfo(value: Value, trace: Trace):
     def promote: Contextual[Unit] = withTrace(trace) {
-      value.promote("Cannot prove the argument is fully initialized. Only fully initialized values are safe to leak.")
+      value.promote("Cannot prove the argument is fully initialized. Only fully initialized values are safe to leak.\nFound = " + value.show + ". ")
     }
 
   /** Evaluate an expression with the given value for `this` in a given class `klass`
@@ -1395,14 +1396,14 @@ object Semantic:
       case Match(selector, cases) =>
         val res = eval(selector, thisV, klass)
         extendTrace(selector) {
-          res.ensureHot("The value to be matched needs to be fully initialized.")
+          res.ensureHot("The value to be matched needs to be fully initialized. Found = " + res.show + ". ")
         }
         eval(cases.map(_.body), thisV, klass).join
 
       case Return(expr, from) =>
         val res = eval(expr, thisV, klass)
         extendTrace(expr) {
-          res.ensureHot("return expression must be fully initialized.")
+          res.ensureHot("return expression must be fully initialized. Found = " + res.show + ". ")
         }
 
       case WhileDo(cond, body) =>

docs/_docs/reference/other-new-features/safe-initialization.md

@@ -6,6 +6,9 @@ nightlyOf: https://docs.scala-lang.org/scala3/reference/other-new-features/safe-
 
 Scala 3 implements experimental safe initialization check, which can be enabled by the compiler option `-Ysafe-init`.
 
+The design and implementation of the initialization checker is described in the
+paper _Safe object initialization, abstractly_ [3].
+
 ## A Quick Glance
 
 To get a feel of how it works, we first show several examples below.
@@ -105,8 +108,8 @@ By _reasonable usage_, we include the following use cases (but not restricted to
 
 ## Principles
 
-To achieve the goals, we uphold three fundamental principles:
-_stackability_, _monotonicity_ and _scopability_.
+To achieve the goals, we uphold following fundamental principles:
+_stackability_, _monotonicity_, _scopability_ and _authority_.
 
 Stackability means that all fields of a class are initialized at the end of the
 class body. Scala enforces this property in syntax by demanding that all fields
@@ -159,41 +162,138 @@ Monotonicity is based on a well-known technique called _heap monotonic
 typestate_ to ensure soundness in the presence of aliasing
 [1]. Roughly speaking, it means initialization state should not go backwards.
 
-Scopability means that there are no side channels to access to partially constructed objects. Control effects like coroutines, delimited
+Scopability means that there are no side channels to access to partially
+constructed objects. Control effects like coroutines, delimited
 control, resumable exceptions may break the property, as they can transport a
 value upper in the stack (not in scope) to be reachable from the current scope.
 Static fields can also serve as a teleport thus breaks this property.  In the
 implementation, we need to enforce that teleported values are transitively
 initialized.
 
-The principles enable _local reasoning_ of initialization, which means:
+The three principles above contribute to _local reasoning about initialization_,
+which means:
 
 > An initialized environment can only produce initialized values.
 
 For example, if the arguments to an `new`-expression are transitively
 initialized, so is the result. If the receiver and arguments in a method call
 are transitively initialized, so is the result.
 
+Local reasoning about initialization gives rise to a fast initialization
+checker, as it avoids whole-program analysis.
+
+The principle of authority goes hand-in-hand with monotonicity: the principle
+of monotonicity stipulates that initialization states cannot go backwards, while
+the principle of authority stipulates that the initialization states may not
+go forward at arbitrary locations due to aliasing. In Scala, we may only
+advance initialization states of objects in the class body when a field is
+defined with a mandatory initializer or at local reasoning points when the object
+becomes transitively initialized.
+
+## Abstract Values
+
+There are three fundamental abstractions for initialization states of objects:
+
+- __Cold__: A cold object may have uninitialized fields.
+- __Warm__: A warm object has all its fields initialized but may reach _cold_ objects.
+- __Hot__: A hot object is transitively initialized, i.e., it only reaches warm objects.
+
+In the initialization checker, the abstraction `Warm` is refined to handle inner
+classes and multiple constructors:
+
+- __Warm[C] { outer = V, ctor, args = Vs }__: A warm object of class `C`, where the immediate outer of `C` is `V`, the constructor is `ctor` and constructor arguments are `Vs`.
+
+The initialization checker checks each class separately. The abstraction `ThisRef`
+represents the current object under initialization:
+
+- __ThisRef[C]__: The current object of class `C` under initialization.
+
+The initialization state of the current object is stored in the heap as an
+abstract object. The abstract heap also serves as a cache for the field values
+of warm objects.
+
+Two more abstractions are introduced to support functions and conditional
+expressions:
+
+- __Fun(e, V, C)__: A abstract function value where `e` is the code, `V` is the
+  abstract value for `this` inside the function body and the function is located
+  inside the class `C`.
+
+- __Refset(Vs)__: A set of abstract values `Vs`.
+
 ## Rules
 
 With the established principles and design goals, following rules are imposed:
 
-1. In an assignment `o.x = e`, the expression `e` may only point to transitively initialized objects.
+1. The field access `e.f` or method call `e.m()` is illegal if `e` is _cold_.
+
+   A cold value should not be used.
+
+2. The field access `e.f` is invalid if `e` has the value `ThisRef` and `f` is not initialized.
+
+3. In an assignment `o.x = e`, the expression `e` must be _effectively hot_.
 
    This is how monotonicity is enforced in the system. Note that in an
-   initialization `val f: T = e`, the expression `e` may point to an object
-   under initialization. This requires a distinction between mutation and
-   initialization in order to enforce different rules. Scala
-   has different syntax for them, it thus is not an issue.
+   initialization `val f: T = e`, the expression `e` may point to an non-hot
+   value.
 
-2. Objects under initialization may not be passed as arguments to method calls.
+4. Arguments to method calls must be _effectively hot_.
 
    Escape of `this` in the constructor is commonly regarded as an anti-pattern.
+
    However, escape of `this` as constructor arguments are allowed, to support
    creation of cyclic data structures. The checker will ensure that the escaped
    non-initialized object is not used, i.e. calling methods or accessing fields
    on the escaped object is not allowed.
 
+   An exception is for calling synthetic `apply`s of case classes. For example,
+   the method call `Some.apply(e)` will be interpreted as `new Some(e)`, thus
+   is valid even if `e` is not hot.
+
+   Another exception too this rule is parametric method calls. For example, in
+   `List.apply(e)`, the argument `e` may be non-hot. If that is the case, the
+   result value of the parametric method call is taken as _cold_.
+
+5. Method calls on hot values with effectively hot arguments produce hot results.
+
+   This rule is assured by local reasoning about initialization.
+
+6. Method calls on `ThisRef` and warm values will be resolved statically and the
+   corresponding method bodies are checked.
+
+7. In a new expression `new p.C(args)`, if the values of `p` and `args` are
+   effectively hot, then the result value is also hot.
+
+   This is assured by local reasoning about initialization.
+
+8. In a new expression `new p.C(args)`, if any value of `p` and `args` is not
+   effectively hot, then the result value takes the form `Warm[C] { outer = Vp, args = Vargs }`. The initialization code for the class `C` is checked again to make
+   sure the non-hot values are used properly.
+
+   In the above, `Vp` is the widened value of `p` --- the widening happens if `p`
+   is a warm value `Warm[D] { outer = V, args }` and we widen it to
+   `Warm[D] { outer = Cold, args }`.
+
+   The variable `Vargs` represents values of `args` with non-hot values widened
+   to `Cold`.
+
+   The widening is motivated to finitize the abstract domain and ensure
+   terimination of the initialization check.
+
+9. The scrutinee in pattern match, the values in return and throw statements must be _effectively hot_.
+
+A value `v` is _effectively hot_ if any of the following is true:
+
+- `v` is `Hot`.
+- `v` is `ThisRef` and all fields of the underlying object are initialized.
+- `v` is `Warm[C] { outer = V, ctor, args = Vs }` and
+  1. `C` does not contain inner classes;
+  2. Calling any method on `v` encounters no errors and the method return value is _effectively hot_;
+  3. Each field of `v` is _effectively hot_.
+- `v` is `Fun(e, V, C)` and calling the function encounters no errors and the
+  function return value is _effectively hot_.
+- `ThisRef` is _effectively hot_.
+
 ## Modularity
 
 The analysis takes the primary constructor of concrete classes as entry points.
@@ -234,3 +334,4 @@ mark some fields as lazy.
 
 1. Fähndrich, M. and Leino, K.R.M., 2003, July. [_Heap monotonic typestates_](https://www.microsoft.com/en-us/research/publication/heap-monotonic-typestate/). In International Workshop on Aliasing, Confinement and Ownership in object-oriented programming (IWACO).
 2. Fengyun Liu, Ondřej Lhoták, Aggelos Biboudis, Paolo G. Giarrusso, and Martin Odersky. 2020. [_A type-and-effect system for object initialization_](https://dl.acm.org/doi/10.1145/3428243). OOPSLA, 2020.
+3. Fengyun Liu, Ondřej Lhoták, Enze Xing, Nguyen Cao Pham. 2021 [_Safe object initialization, abstractly_](https://dl.acm.org/doi/10.1145/3486610.3486895)

tests/init/neg/closureLeak.check

@@ -1,14 +1,16 @@
 -- Error: tests/init/neg/closureLeak.scala:11:14 -----------------------------------------------------------------------
 11 |    l.foreach(a => a.addX(this)) // error
    |              ^^^^^^^^^^^^^^^^^
-   |  Cannot prove the argument is fully initialized. Only fully initialized values are safe to leak. Calling trace:
-   |  -> class Outer {	[ closureLeak.scala:1 ]
-   |     ^
-   |  -> l.foreach(a => a.addX(this)) // error	[ closureLeak.scala:11 ]
-   |               ^^^^^^^^^^^^^^^^^
+   |              Cannot prove the argument is fully initialized. Only fully initialized values are safe to leak.
+   |              Found = Fun { this = ThisRef[class Outer], owner = class Outer }.  Calling trace:
+   |              -> class Outer {	[ closureLeak.scala:1 ]
+   |                 ^
+   |              -> l.foreach(a => a.addX(this)) // error	[ closureLeak.scala:11 ]
+   |                           ^^^^^^^^^^^^^^^^^
    |
-   |  Promoting the value to fully initialized failed due to the following problem:
-   |  Cannot prove the argument is fully initialized. Only fully initialized values are safe to leak.
-   |  Non initialized field(s): value p. Calling trace:
-   |  -> l.foreach(a => a.addX(this)) // error	[ closureLeak.scala:11 ]
-   |                           ^^^^
+   |              Promoting the value to fully initialized failed due to the following problem:
+   |              Cannot prove the argument is fully initialized. Only fully initialized values are safe to leak.
+   |              Found = ThisRef[class Outer]. 
+   |              Non initialized field(s): value p. Calling trace:
+   |              -> l.foreach(a => a.addX(this)) // error	[ closureLeak.scala:11 ]
+   |                                       ^^^^

tests/init/neg/cycle-structure.check

@@ -8,7 +8,7 @@
   |                       ^^^^^^^
   |
   |            It leads to the following error during object initialization:
-  |            Access field on a value with an unknown initialization status. Calling trace:
+  |            Access field value x on a cold object. Calling trace:
   |            -> case class B(a: A) {	[ cycle-structure.scala:7 ]
   |               ^
   |            -> val x1 = a.x	[ cycle-structure.scala:8 ]
@@ -23,7 +23,7 @@
   |                       ^^^^^^^
   |
   |            It leads to the following error during object initialization:
-  |            Access field on a value with an unknown initialization status. Calling trace:
+  |            Access field value x on a cold object. Calling trace:
   |            -> case class A(b: B) {	[ cycle-structure.scala:1 ]
   |               ^
   |            -> val x1 = b.x	[ cycle-structure.scala:2 ]

tests/init/neg/default-this.check

@@ -2,6 +2,7 @@
 9 |        compare() // error
   |        ^^^^^^^
   |        Cannot prove the argument is fully initialized. Only fully initialized values are safe to leak.
+  |        Found = ThisRef[class B]. 
   |        Non initialized field(s): value result. Calling trace:
   |        -> class B extends A {	[ default-this.scala:6 ]
   |           ^

tests/init/neg/i15363.check

@@ -8,7 +8,7 @@
   |                     ^^^^^^^^^^^
   |
   |          It leads to the following error during object initialization:
-  |          Access field on a value with an unknown initialization status. Calling trace:
+  |          Access field value m on a cold object. Calling trace:
   |          -> class B(a: A):	[ i15363.scala:7 ]
   |             ^
   |          -> val x = a.m	[ i15363.scala:8 ]

tests/init/neg/i15459.check

@@ -2,6 +2,7 @@
 3 |  println(this)  // error
   |          ^^^^
   |          Cannot prove the argument is fully initialized. Only fully initialized values are safe to leak.
+  |          Found = ThisRef[class Sub]. 
   |          Non initialized field(s): value b. Calling trace:
   |          -> class Sub extends Sup:	[ i15459.scala:5 ]
   |             ^

tests/init/neg/inherit-non-hot.check

@@ -12,4 +12,4 @@
   |                     ^^^^^^^^^^^^^^^
   |
   |Promoting the value to fully initialized failed due to the following problem:
-  |Cannot prove that the field val a is fully initialized.
+  |Cannot prove that the field value a is fully initialized. Found = Cold. 

tests/init/neg/inlined-method.check

@@ -2,6 +2,7 @@
 8 |    scala.runtime.Scala3RunTime.assertFailed(message) // error
   |                                             ^^^^^^^
   |                   Cannot prove the argument is fully initialized. Only fully initialized values are safe to leak.
+  |                   Found = ThisRef[class InlineError]. 
   |                   Non initialized field(s): value v. Calling trace:
   |                   -> class InlineError {	[ inlined-method.scala:1 ]
   |                      ^

tests/init/neg/inner-first.check

@@ -2,6 +2,7 @@
 3 |    println(this)           // error
   |            ^^^^
   |            Cannot prove the argument is fully initialized. Only fully initialized values are safe to leak.
+  |            Found = ThisRef[class B]. 
   |            Non initialized field(s): value n. Calling trace:
   |            -> class B:	[ inner-first.scala:2 ]
   |               ^

tests/init/neg/leak-warm.check

@@ -1,7 +1,7 @@
 -- Error: tests/init/neg/leak-warm.scala:19:18 -------------------------------------------------------------------------
 19 |    val l2 = l.map(_.m()) // error
    |             ^^^^^^^^^^^^
-   |             Call method on a value with an unknown initialization. Calling trace:
+   |             Call method method map on a cold object. Calling trace:
    |             -> object leakWarm {	[ leak-warm.scala:1 ]
    |                ^
    |             -> val l2 = l.map(_.m()) // error	[ leak-warm.scala:19 ]

tests/init/neg/promotion-loop.check

@@ -1,12 +1,13 @@
 -- Error: tests/init/neg/promotion-loop.scala:16:10 --------------------------------------------------------------------
 16 |  println(b)      // error
    |          ^
-   |  Cannot prove the argument is fully initialized. Only fully initialized values are safe to leak. Calling trace:
-   |  -> class Test { test =>	[ promotion-loop.scala:1 ]
-   |     ^
-   |  -> println(b)      // error	[ promotion-loop.scala:16 ]
+   |          Cannot prove the argument is fully initialized. Only fully initialized values are safe to leak.
+   |          Found = Warm[class B] { outer = ThisRef[class Test] }.  Calling trace:
+   |          -> class Test { test =>	[ promotion-loop.scala:1 ]
    |             ^
+   |          -> println(b)      // error	[ promotion-loop.scala:16 ]
+   |                     ^
    |
-   |  Promoting the value to fully initialized failed due to the following problem:
-   |  Cannot prove that the field val outer is fully initialized.
-   |  Non initialized field(s): value n.
+   |          Promoting the value to fully initialized failed due to the following problem:
+   |          Cannot prove that the field value outer is fully initialized. Found = ThisRef[class Test]. 
+   |          Non initialized field(s): value n.