-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Disallow opaque type aliases of context functions #16041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1460,6 +1460,15 @@ trait Checking { | |
|CanThrow capabilities can only be generated $req.""", | ||
pat.srcPos) | ||
|
||
/** Check that tree does not define a context fucntion type */ | ||
def checkNoContextFunctionType(tree: Tree)(using Context): Unit = | ||
def recur(tp: Type): Unit = tp.dealias match | ||
case tp: HKTypeLambda => recur(tp.resType) | ||
case tp if defn.isContextFunctionType(tp) => | ||
report.error(em"context functon type cannot have opaque aliases", tree.srcPos) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. typo |
||
case _ => | ||
recur(tree.tpe) | ||
|
||
/** (1) Check that every named import selector refers to a type or value member of the | ||
* qualifier type. | ||
* (2) Check that no import selector is renamed more than once. | ||
|
@@ -1495,6 +1504,7 @@ trait ReChecking extends Checking { | |
override def checkNoModuleClash(sym: Symbol)(using Context) = () | ||
override def checkCanThrow(tp: Type, span: Span)(using Context): Tree = EmptyTree | ||
override def checkCatch(pat: Tree, guard: Tree)(using Context): Unit = () | ||
override def checkNoContextFunctionType(tree: Tree)(using Context): Unit = () | ||
override def checkFeature(name: TermName, description: => String, featureUseSite: Symbol, pos: SrcPos)(using Context): Unit = () | ||
} | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
object Scope: | ||
opaque type Uses[A, B] = A ?=> B // error | ||
opaque type UsesAlt = [A, B] =>> A ?=> B // error | ||
|
||
object Uses: | ||
def apply[A, B](fn: A ?=> B): Uses[A, B] = fn | ||
|
||
import Scope.* | ||
val uses = | ||
given Int = 1 | ||
Uses[Int, String](i ?=> s"*$i*") | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
trait S: | ||
type Uses[A, B] <: A ?=> B | ||
object Uses: | ||
def apply[A, B](fn: A ?=> B): Uses[A, B] = fn // error | ||
val uses1 = | ||
given Int = 1 | ||
Uses[Int, String](i ?=> s"*$i*") | ||
|
||
object I extends S: | ||
type Uses[A, B] = A ?=> B | ||
val uses2 = | ||
given Int = 1 | ||
Uses[Int, String](i ?=> s"*$i*") | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
object Scope: | ||
type Uses[A, B] = A ?=> B | ||
|
||
object Uses: | ||
def apply[A, B](fn: A ?=> B): Uses[A, B] = fn | ||
|
||
import Scope.* | ||
val uses = | ||
given Int = 1 | ||
Uses[Int, String](i ?=> s"*$i*") | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also typo function