Fix #1643: More robust untpd.New #1660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We assumed that argument types in an untpd.New are never wildcards but in the face of errors that is not true.
These might lead to bad bounds if unchecked.
Scalac disallows them also, but with a confusing error message
("class type expected" on the class).
smarter
reviewed
Nov 5, 2016
| tpt1 match { | ||
| case AppliedTypeTree(_, targs) => | ||
| for (targ @ TypeBoundsTree(_, _) <- targs) | ||
| ctx.error("type argument must be fully defined", targ.pos) |
There was a problem hiding this comment.
I think it would be better to not introduce new string error messages and to make a new error message class by following Felix's guide instead: #1589
There was a problem hiding this comment.
Agreed in principle, but I think it's best to leave that to others who are already in it. Crafting a good error message takes time. But my goal here is to clear the backlog of fuzzing errors, so I want to move quickly.
|
Alright, updated #1589 with the new error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, disallow wildcard arguments in new.
Review by @smarter.