Skip to content

fix #1701: disqualify package name in type name resolution #1720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 17, 2016

Conversation

liufengyun
Copy link
Contributor

Fix #1701 : disqualify package name in type name resolution

Review @odersky

@odersky
Copy link
Contributor

odersky commented Nov 17, 2016

I think here we should try to prevent the problem at the root. Can you try to change line 431 in Symbols.scala to the following:

  if (this.is(Module, butNot = Package)) this.owner.asClass.enter(this.moduleClass)

Then we won't have add more clauses to qualifies.

@liufengyun
Copy link
Contributor Author

@odersky I tried and it works!

@odersky
Copy link
Contributor

odersky commented Nov 17, 2016

LGTM :-)

@odersky odersky merged commit 156a9d9 into scala:master Nov 17, 2016
@liufengyun liufengyun deleted the fix-i1701 branch November 17, 2016 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants