Skip to content

Fix stdlib-bootstrapped private case class constructors #17974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Jun 14, 2023

In the Scala 2 the apply and copy of a private case class constructor are public in the pickles and bytecode.

@nicolasstucki nicolasstucki self-assigned this Jun 14, 2023
@nicolasstucki nicolasstucki force-pushed the stdlib-bootstrapped-private-case-class-constructor branch from 9c78a6f to f5bd16a Compare June 14, 2023 14:41
@nicolasstucki nicolasstucki marked this pull request as ready for review June 14, 2023 16:08
@nicolasstucki nicolasstucki requested a review from sjrd June 15, 2023 09:17
@nicolasstucki nicolasstucki assigned sjrd and unassigned nicolasstucki Jun 15, 2023
@nicolasstucki nicolasstucki force-pushed the stdlib-bootstrapped-private-case-class-constructor branch from f5bd16a to 4a4ea7b Compare June 15, 2023 13:03
In the Scala 2 the `apply` and `copy` of a private case class
constructor are public in the pickles and bytecode.
@nicolasstucki nicolasstucki force-pushed the stdlib-bootstrapped-private-case-class-constructor branch from 4a4ea7b to a80f3d7 Compare June 23, 2023 13:34
@nicolasstucki nicolasstucki enabled auto-merge June 23, 2023 14:42
@nicolasstucki nicolasstucki merged commit 171849f into scala:main Jun 23, 2023
@nicolasstucki nicolasstucki deleted the stdlib-bootstrapped-private-case-class-constructor branch June 23, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants