Fix #1795: Avoid infinite recursion between member and asSeenFrom #1848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
smarter
reviewed
Dec 21, 2016
| @@ -67,7 +68,10 @@ trait TypeOps { this: Context => // TODO: Make standalone object. | |||
| if (thiscls.derivesFrom(cls) && pre.baseTypeRef(thiscls).exists) { | |||
| if (theMap != null && theMap.currentVariance <= 0 && !isLegalPrefix(pre)) { | |||
| ctx.base.unsafeNonvariant = ctx.runId | |||
| AnnotatedType(pre, Annotation(defn.UnsafeNonvariantAnnot, Nil)) | |||
| pre match { | |||
| case AnnotatedType(_, ann) if ann.symbol == defn.UnsafeNonvariantAnnot => pre | |||
There was a problem hiding this comment.
No it's related. Before we were running into the member/asSeenFrom mutual recursion we stackoverflowed here. Avoiding this by not piling up the same annotation makes sense independently.
smarter
reviewed
Dec 21, 2016
| * of recursive member searches. If the limit is reached, findMember returns | ||
| * NoDenotation. | ||
| */ | ||
| val findMemberLimit = new Property.Key[Int] |
There was a problem hiding this comment.
Since PendingFindMemberLimit is a constant I would just make this a boolean
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review by @smarter ?