Fix #1868: Fix a logic error in a match #1869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a by-name arg has a bottom type, we need to create a closure with the result type of the formal parameter, or else specialization with FunctionalInterfaces will fail.
smarter
reviewed
Jan 3, 2017
| @@ -1150,7 +1150,7 @@ class Typer extends Namer with TypeAssigner with Applications with Implicits wit | |||
| // classes defined in a such arguments should not be entered into the | |||
| // enclosing class. | |||
| c.exprContext(mdef, exprOwner) | |||
| case None => c | |||
There was a problem hiding this comment.
This is a perfect example of why we shouldn't turn off exhaustiveness warnings when guards are used ;) (cf: scala/scala#5617)
| @@ -1150,7 +1150,7 @@ class Typer extends Namer with TypeAssigner with Applications with Implicits wit | |||
| // classes defined in a such arguments should not be entered into the | |||
There was a problem hiding this comment.
while you're at it, you could fix the typo here: "in a such" -> "in such"
|
The other PR got merged, so this one can go in as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.