Fix compileStdLib test #1872
Merged
Fix compileStdLib test #1872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
fix-compileStdLib-test
branch
2 times, most recently
from
49376d3 to
61985a1
Compare
liufengyun
reviewed
Jan 3, 2017
| @@ -245,7 +245,7 @@ class tests extends CompilerTest { | |||
| } | |||
|
|
|||
|
|
|||
| @Test def compileStdLib = compileList("compileStdLib", stdlibFiles, "-migration" :: "-Yno-inline" :: scala2mode) | |||
| @Test def compileStdLib = compileList("compileStdLib", stdlibFiles.map(_.replace("../scala-scala/src/library/", "")), "-migration" :: "-Yno-inline" :: scala2mode, Directory("../scala-scala/src/library/")) | |||
| @Test def compileMixed = compileLine( | |||
There was a problem hiding this comment.
This line looks a little strange, it seems the change can cancel each other? Otherwise, LGTM.
There was a problem hiding this comment.
Updated with a less intrusive change.
There was a problem hiding this comment.
I've a minor question here: for other calls of compileList, we ignore the option sourceDir. It would be nice to add a comment for compileList to document the condition when this option can be ignored.
nicolasstucki
force-pushed
the
fix-compileStdLib-test
branch
2 times, most recently
from
0060241 to
e0e1730
Compare
The issue was that all the files stdlib files where copied in partest-generated/pos/compileStdLib direclty (i.e. directories flattend). This implies that files with the same names would overwrite eachother (like `package.scala` and `Set.scala`).
nicolasstucki
force-pushed
the
fix-compileStdLib-test
branch
from
e0e1730 to
25d4f8e
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was that all the files stdlib files where copied in
partest-generated/pos/compileStdLibdirectly (i.e. directories flattend). This implies that files with the same names would overwrite each other (likepackage.scalaandSet.scala).