Skip to content

Trees#namePos: Correct position for objects #1952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 8, 2017
Merged

Trees#namePos: Correct position for objects #1952

merged 1 commit into from
Feb 8, 2017

Conversation

smarter
Copy link
Member

@smarter smarter commented Feb 6, 2017

Review by @odersky, can you think of other situations where the tree name after typer is different from the source name?

@smarter smarter force-pushed the fix/object-namePos branch from 180d39e to fa64b4b Compare February 6, 2017 17:45
@xeno-by
Copy link

xeno-by commented Feb 7, 2017

@smarter What about backticks?

@smarter
Copy link
Member Author

smarter commented Feb 7, 2017

@xeno-by pos.point should correspond to the first character in the name that is not a backtick, so it should be okay

@odersky
Copy link
Contributor

odersky commented Feb 8, 2017

LGTM

@odersky
Copy link
Contributor

odersky commented Feb 8, 2017

Review by @odersky, can you think of other situations where the tree name after typer is different from the source name?

I don't think there are other instances (module encode/decode)

@odersky odersky merged commit 56ad4b1 into scala:master Feb 8, 2017
@allanrenucci allanrenucci deleted the fix/object-namePos branch December 14, 2017 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smarter @xeno-by @odersky @dottybot