Skip to content

Ennru forward reference error #1973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 14, 2017
Merged

Ennru forward reference error #1973

merged 4 commits into from
Feb 14, 2017

Conversation

ennru
Copy link
Contributor

@ennru ennru commented Feb 13, 2017

@felixmulder
Another awsome error message giving more relevant context.

There seem to be other checks for this error around that expect the old message, but I did not find out how to run those tests.

I removed the ctx.debuglog as that symbol is now included in the message.

@felixmulder
Copy link
Contributor

@liufengyun - debug test failing in this build. Could you investigate?

@liufengyun
Copy link
Contributor

@felixmulder I just restarted the test, seems to be some non-determinism. I have reduced the probability it can happen last week. If it happens > 5%, I am happy to disable it for the moment, until I figure out a solution.

@felixmulder felixmulder merged commit 47901c0 into scala:master Feb 14, 2017
@felixmulder
Copy link
Contributor

@liufengyun - I'll be at the office in an hour, let's talk about it then. I'd like to eliminate the non-determinism if possible: in a couple of years this knowledge could be lost.

@felixmulder
Copy link
Contributor

Thanks @ennru !

@ennru ennru deleted the ennru_ForwardReferenceError branch February 14, 2017 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants