-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add Phantom type docs #2519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Phantom type docs #2519
Conversation
docs/docs/reference/phantom-types.md
Outdated
title: "Phantom Types" | ||
--- | ||
|
||
Phantom Types :ghost: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will give you the title twice
docs/docs/reference/phantom-types.md
Outdated
they live? The answer is in their own type universes bounded by their phantom `Any` and `Nothing`. | ||
In fact we allow multiple phantom universes to exist. | ||
|
||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The highlighting component might try to guess a language here - do ```none
to suppress it if that's the case.
docs/sidebar.yml
Outdated
@@ -3,6 +3,10 @@ sidebar: | |||
url: blog/index.html | |||
- title: Docs | |||
url: docs/index.html | |||
- title: Reference |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we call this "Language Reference"? I'm guessing you're following suit on what @odersky is doing with his docs. Did we decide to change this yesterday?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will rebase on whatever the result of of the other one is.
ecf6ef5
to
1120228
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated phantom-types.md
directly
71203f1
to
f0eeea3
Compare
Status of this? The main page currently 404s on linking to phantom types. |
When scala#2519 is merged, this change should be revisited.
Before scala#2519 is merged, this fix should be revisited
Fixed in: #2674 But this PR should update with the correct link on the landing page. |
f0eeea3
to
3e60d97
Compare
@felixmulder I updated the link and rebased. It should be ready to go in. |
3e60d97
to
a5eacd0
Compare
@nicolasstucki LGTM |
@biboudis - you can merge things if you give your "LGTM", Aggy :) |
No description provided.