Skip to content

Add Phantom type docs #2519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 5, 2017
Merged

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

title: "Phantom Types"
---

Phantom Types :ghost:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will give you the title twice

they live? The answer is in their own type universes bounded by their phantom `Any` and `Nothing`.
In fact we allow multiple phantom universes to exist.

```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The highlighting component might try to guess a language here - do ```none to suppress it if that's the case.

docs/sidebar.yml Outdated
@@ -3,6 +3,10 @@ sidebar:
url: blog/index.html
- title: Docs
url: docs/index.html
- title: Reference
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we call this "Language Reference"? I'm guessing you're following suit on what @odersky is doing with his docs. Did we decide to change this yesterday?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will rebase on whatever the result of of the other one is.

Copy link
Contributor

@biboudis biboudis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated phantom-types.md directly

@felixmulder
Copy link
Contributor

Status of this? The main page currently 404s on linking to phantom types.

felixmulder added a commit to dotty-staging/dotty that referenced this pull request Jun 4, 2017
When scala#2519 is merged, this change should be revisited.
felixmulder added a commit to dotty-staging/dotty that referenced this pull request Jun 4, 2017
Before scala#2519 is merged, this fix should be revisited
@felixmulder
Copy link
Contributor

Fixed in: #2674

But this PR should update with the correct link on the landing page.

@nicolasstucki
Copy link
Contributor Author

@felixmulder I updated the link and rebased. It should be ready to go in.
@biboudis do you still agree?

@biboudis
Copy link
Contributor

biboudis commented Jun 4, 2017

@nicolasstucki LGTM

@felixmulder
Copy link
Contributor

@biboudis - you can merge things if you give your "LGTM", Aggy :)

@felixmulder felixmulder merged commit 41085c8 into scala:master Jun 5, 2017
@allanrenucci allanrenucci deleted the phantom-doc-1 branch December 14, 2017 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants