Fix array creation v2 #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now: All new Array[T] methods are translated to calls of the form
dotty.Arrays.newXYZArray ...
odersky
changed the title
| /** Create an array of type T. T must be of form Array[E], with | ||
| * E being a reference type. | ||
| */ | ||
| def newRefArray[T](length: Int): T = ??? |
There was a problem hiding this comment.
Is return type T instead of Array[T] here intentional?
There was a problem hiding this comment.
From the comment: "T must be of form Array[E]". So yes, I suppose it is intentional.
There was a problem hiding this comment.
Yes, that's intentional. It's a technically to fit best with the way erasure works for polymorphic functions. That way, we can treat newRefArray and asInstanceOf in exactly the same way.
tgodzik
added a commit
to tgodzik/scala3
that referenced
this pull request
Apr 29, 2025
Backport "Fix issue with static `this` references erroring in quoted code" to 3.3 LTS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now: All new Array[T] methods are translated to calls of the form
Supersedes #252. Main change is that we now keep ref array types after erasure, and that we
allow for local type inference of array creation arguments, i.e. new Array(len), without a type argument.
Review by @DarkDimius please.