Fix/type seqliteral #261
Merged
Fix/type seqliteral #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid to create ArrayTypes after erase. Note that the *extractor* does not recognize JavaArrayTypes as ArrayTypes. Doing so would create an infinite loop in sigName. Generally, we do not want to ppaper over the difference when analysing types.
When hash-consing TypeBounds, RefinedTypes and NamedTypes, we now check the argument types with `eq`, where before it was `==`. This is necessary for TypeBounds, because it makes a difference whether a TypeBound has `eq` parts (then it is a type alias) or not. So we cannot merge type aliases with non-aliases. The symptom of the problem was when compiling Patterns.scala twice with the new SeqLiterals phase (next commit) enabled. On second run, we encountered an ArrayType[>: String <: String], even if we only created an ArrayType[String]. This was a consequence of the two types being identified by uniques. Todo: Change the system so that type aliases are recognized more robustly. But the present change seems to be useful anyway because it speeds up uniques hashing. I verified that the stricter condition on uniques creates less than 1% more types than before. So the speedup of hashing looks worthwhile.
Replaces SeqLiterals by JavaSeqLiterals, because the latter's (array-)type is preserved after erasure.
|
@odersky thanks for a good fix. Works great! |
tgodzik
added a commit
to tgodzik/scala3
that referenced
this pull request
Apr 29, 2025
Backport "Constructor companion gets privateWithin" to 3.3 LTS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed typing of SeqLiterals. Review by @DarkDimius