Skip to content

Pass right prototype to SeqLiteral elements. #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 12, 2014

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Dec 5, 2014

Review by @DarkDimius

@@ -374,6 +374,10 @@ object Erasure extends TypeTestsCasts{
}
}

override def typedSeqLiteral(tree: untpd.SeqLiteral, pt: Type)(implicit ctx: Context) =
super.typedSeqLiteral(tree, tree.typeOpt)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pt here will end up being unerazed type, so adapt will not be called.

Fixed two problems with previous commit.
@DarkDimius
Copy link
Contributor

@odersky, works! thanks.

DarkDimius added a commit that referenced this pull request Dec 12, 2014
Pass right prototype to SeqLiteral elements.
@DarkDimius DarkDimius merged commit 1ce4c34 into scala:master Dec 12, 2014
@allanrenucci allanrenucci deleted the fix/type-seqliteral branch December 14, 2017 19:23
tgodzik added a commit to tgodzik/scala3 that referenced this pull request Apr 29, 2025
Backport "Make overload pruning based on result types less aggressive" to 3.3 LTS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants