Skip to content

DLS: do not swallow exceptions in initialization #2708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import java.net.URI
import java.io._
import java.nio.file._
import java.util.concurrent.CompletableFuture
import java.util.function.Function

import com.fasterxml.jackson.databind.ObjectMapper

Expand Down Expand Up @@ -133,6 +134,15 @@ class DottyLanguageServer extends LanguageServer
// Do most of the initialization asynchronously so that we can return early
// from this method and thus let the client know our capabilities.
CompletableFuture.supplyAsync(() => drivers)
.exceptionally {
// Can't use a function literal here because of #2367
new Function[Throwable, Nothing] {
def apply(ex: Throwable) = {
ex.printStackTrace
sys.exit(1)
}
}
}

new InitializeResult(c)
}
Expand Down