Move dotty compiler code to compiler.internal #28
Conversation
|
Sorry for the frequent editing. I think I'm done now. |
This commit moves all code that was in dotty.tools into dotty.compiler.internal. The idea of a "tools" package seems to be a holdover from "com.sun.tools.javac". This naming style is not in line with how packages are normally named in the standard Scala distribution, hence the change. Note that I've done my best to update tests to make them compile/run, but some tests that did not compile before still don't compile with this commit. These tests are not in the set run by "sbt test", so I believe them to be stale (in fact, they should likely be removed in a future commit).
|
That seems reasonable. The removal of outputs in the worksheets (few last files in the diff) is suspicious, though. |
|
This is how my Eclipse (apparently) saved them after I went through each worksheet, updating package names to get it to compile, if possible. A couple of them would not compile because they referenced fields that are no longer present in objects. These fields were already gone before this commit, so those worksheets were already noncompiling. In any case, It seems that "sbt test" isn't compiling/running those worksheets, anyway, so I'm really wondering what they are for. |
|
In any case, I will investigate getting this repushed with the outputs restored later. Please don't merge until I've done that. |
|
As a minor update, there's something weird going on with my worksheets. Will investigate before reopening. |
Optimize Methods in NullOpsDecorator; Optimize widenUnion
Note: I consider this to be a work-in-progress and accept that I may have to make some additional changes to get this pull request through.
This commit moves all code that was in dotty.tools into dotty.compiler.internal. The idea of a "tools" package seems to be a holdover from "com.sun.tools.javac". This naming style is not in line with how packages are normally named in the standard Scala distribution, hence the change. Note that I've done my best to update tests to make them compile/run, but some tests that did not compile before still don't compile with this commit. These tests are not in the set run by "sbt test", so I believe them to be stale (in fact, they should likely be removed in a future commit).