Run rewrite tool on tests #287
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These changes increase the build time on Travis from ca 6min to 10min, and the output from ca 8K lines to 14K lines. Hope this doesn't cause too much trouble... |
|
Almost doubling the test time is not good for productivity. I propose we do this in stages. Can you do a separate PR with just the files that break in tests/pos/pending? That would let us work on the failures now. At the same time we need to get partest up and running. If we can do the tests in parallel we should regain some of the speed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran the latest version of the rewrite tool on
tests/untried/pos. Then I also ran a script which moves those test which succeed fromtests/untried/postotests/pos.So all 293 tests which are still in
tests/untried/posare failing, and we can start tackling these ;-)