Fix #2300: Try to heal subtype failures by instantiating type variables #2896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riables The idea is that if an adapt fails because an actual type A is not a subtype of an expected type B, we try to instantiate all type variables in A and, if that changes something, try again. This mitigates the discrepancy that dotc is more lazy in instantiating type variables than scalac. Fixes scala#2300.
Commit only if the adapt following the instantiation is error-free. DottyLanguageServer had a compilation failure due to the previous scheme.
DottyLanguageServer contained an example that shows that we should not instantiate type variables before trying an implicit conversion.
smarter
approved these changes
Jul 21, 2017
|
The latest speedup most likely comes from this PR -- due to some reordering of the commits, the graph doesn't point to the correct PR. |
Can you explain that? What reordering of commits? It'd be good if the graph was accurate. |
|
Now it's clear -- the drop is due to my restarting of the testing server this morning. I've fixed the CPU to a determined frequency, the restart lost the setting. Now I restored the setting (permanent), re-ran all tests for this morning and the graphs are explainable. The graph does point to the correct PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is that if an adapt fails because an actual type A is not a
subtype of an expected type B, we try to instantiate all type variables
in A and, if that changes something, try again.
This mitigates the discrepancy that dotc is more lazy in instantiating type
variables than scalac.
Fixes #2300.