Fix #2564: Do not create ill-formed <init> accessors #2904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This just a first small step to ensure that the compiler does not crash on inlined private constructors. |
liufengyun
reviewed
Jul 24, 2017
| accessedType = methPart.tpe.widen, | ||
| rhs = (qual, tps, argss) => qual.appliedToTypes(tps).appliedToArgss(argss)) | ||
| val mSym = methPart.symbol | ||
| if (mSym.isConstructor && (mSym.is(Private) || mSym.privateWithin.exists)) { |
There was a problem hiding this comment.
Do we need to check privateWithin, is it subsumed by the private check?
There was a problem hiding this comment.
I thought so too but when trying it out I found that it was not the case. Should it be? Did I stumble on another bug?
There was a problem hiding this comment.
The privateWithin check is fine, https://github.com/lampepfl/dotty/blob/master/compiler/src/dotty/tools/dotc/typer/Inliner.scala#L49.
There was a problem hiding this comment.
Actually I should use mSym.isConstructor && needsAccessor(mSym)
liufengyun
approved these changes
Jul 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.