Avoid spurious warnings about forward references in refinements #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -759,10 +759,11 @@ class Typer extends Namer with TypeAssigner with Applications with Implicits wit | |||
| val refineClsDef = desugar.refinedTypeToClass(tpt1, tree.refinements) | |||
| val refineCls = createSymbol(refineClsDef).asClass | |||
| val TypeDef(_, Template(_, _, _, refinements1)) = typed(refineClsDef) | |||
| var seen = mutable.Set[Symbol]() | |||
There was a problem hiding this comment.
Since it's a mutable set, can be a val, not a var.
|
Otherwise LGTM. |
The warning was triggered by cases like:
class A
type F = A { type T = Int; def f: T }
Which is treated differently from the following which did not produce a warning:
type F = A { type T = Int } { def f: T }
smarter
force-pushed
the
fix/multiple-refinements-warning
branch
from
ace49ca to
5fced3a
Compare
DarkDimius
added a commit
that referenced
this pull request
Dec 16, 2014
Avoid spurious warnings about forward references in refinements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The warning was triggered by cases like:
class A
type F = A { type T = Int; def f: T }
Which is treated differently from the following which did not produce a warning:
type F = A { type T = Int } { def f: T }
Review by @odersky