Fix/returns #302
Merged
Fix/returns #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return proto type was wrong; it was the type of the method (with PolyParams if that type is polymorphic), where it should have been the return type instantiated with the local type parameters. We now instantiate the prototype as required. Note the typing of return nodes is a bit more subtle than in scalac, because dotc trees are immutable, so the tree pointed at by the context is of no help - it does not have a return type which we could make use of.
Explanation given in the comment.
If this commit is made without the previous fixes to returns, we get errors in dotc_parsing (without the fix to polymorphic returns) and in dotc_core (without the fix in tree transform).
isSuppressed forces computation of the error message; should be called only when emitting the error. TODO: Generalize so that other emitting reporters inherit the behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several fixes to returns, and one to error reporting. Review by @DarkDimius. Supersedes #297.