Avoid most deep subtypes in test #3272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
force-pushed
the
fix-deep-subtypes
branch
2 times, most recently
from
dc0a053 to
bde360b
Compare
|
test performance please |
|
performance test scheduled: 9 job(s) in queue, 1 running. |
The only remaining testcase requiring deep subtype is t8146a.scala for good reasons.
smarter
force-pushed
the
fix-deep-subtypes
branch
from
bde360b to
eb2fdf2
Compare
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/3272/ to see the changes. Benchmarks is based on merging with master (af528a1) |
odersky
reviewed
Oct 6, 2017
| // below never contain TypeRefs whose underling types contain | ||
| // uninstantiated TypeVars, this could lead to cycles in `isSubType` | ||
| // as a TypeVar might get constrained by a TypeRef it's part of. | ||
| val tp1a = fullyDefinedType(tp1, "alternative", alt1.symbol.pos).asInstanceOf[PolyType] |
There was a problem hiding this comment.
I wonder whether we could optimize this so that we do the fullyDefinedType only if the type parameter bounds are non-trivial. fullyDefinedType is somewhat expensive.
odersky
reviewed
Oct 6, 2017
| val tparams = ctx.newTypeParams(alt1.symbol, tp1.paramNames, EmptyFlags, tp1.instantiateBounds) | ||
| isAsSpecific(alt1, tp1.instantiate(tparams.map(_.typeRef)), alt2, tp2) | ||
| val nestedCtx = ctx.fresh.setExploreTyperState() | ||
|
|
There was a problem hiding this comment.
I believe we can use TyperState.test here/ It's cheaper and easier to use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only remaining testcase requiring deep subtype is t8146a.scala for
good reasons.