isAsSpecific: restrict usage of fullyDefinedType #3276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
force-pushed
the
fix-deep-subtypes-2
branch
from
3e56949 to
9c5e179
Compare
|
test performance please |
We only need to fully define the bounds of the PolyType parameters, not the whole PolyType.
smarter
force-pushed
the
fix-deep-subtypes-2
branch
from
9c5e179 to
f49e653
Compare
|
performance test scheduled: 7 job(s) in queue, 1 running. |
odersky
reviewed
Oct 6, 2017
| fullyDefinedType(tp1Params, "type parameters of alternative", alt1.symbol.pos) | ||
|
|
||
| val tparams = ctx.newTypeParams(alt1.symbol, tp1.paramNames, EmptyFlags, tp1.instantiateBounds) | ||
| isAsSpecific(alt1, tp1.instantiate(tparams.map(_.typeRef)), alt2, tp2) |
There was a problem hiding this comment.
I have the impression it would be easier to just scan the type parameter bounds whether a fullyDefinedType is needed and, if yes, instantiate the whole type.
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/3276/ to see the changes. Benchmarks is based on merging with master (2ecd3d2) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only need to fully define the bounds of the PolyType parameters, not the
whole PolyType.