Fix #3279 #3297
Merged
Fix #3279 #3297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixmulder
approved these changes
Oct 10, 2017
|
Can I write sbt scipted tests that test the console? |
allanrenucci
force-pushed
the
fix-#3279
branch
from
08325d8 to
5c294cd
Compare
|
I'll defer that to @smarter :) |
smarter
reviewed
Oct 10, 2017
|
|
||
| /** the compiler's classpath, as URL's */ | ||
| val compilerClasspath: Seq[URL] = ctx.platform.classPath(ctx).asURLs | ||
| private var _classLoader: ClassLoader = _ |
There was a problem hiding this comment.
private[this]. Also we usuallly call these variables myFoo instead of _foo.
smarter
approved these changes
Oct 10, 2017
When using the repl through "sbt console", we used to use the class loader sbt give us. But we need a class loader that has the output directory of the compiler on the classpath
allanrenucci
force-pushed
the
fix-#3279
branch
from
5c294cd to
43aab76
Compare
We need to support "initialCommands" in the repl, otherwise this tests nothing...
allanrenucci
force-pushed
the
fix-#3279
branch
from
43aab76 to
061fdb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the repl through "sbt console", we used to use the class
loader sbt give us. But we need a class loader that has the output
directory of the compiler on the classpath