Remove redundant conversion of settings to array #3384
Conversation
Taking into account that `settings` is of type `Array[String]`, there is no need to convert `settings` to array.
| @@ -89,7 +89,7 @@ class ReplDriver(settings: Array[String], | |||
| /** Create a fresh and initialized context with IDE mode enabled */ | |||
| private[this] def initialCtx = { | |||
| val rootCtx = initCtx.fresh.addMode(Mode.ReadPositions).addMode(Mode.Interactive) | |||
| val ictx = setup(settings.toArray, rootCtx)._2.fresh | |||
| val ictx = setup(settings, rootCtx)._2.fresh | |||
There was a problem hiding this comment.
This was probably intended, as it creates a new Array making sure that it cannot be modified from outside the ReplDriver.
There was a problem hiding this comment.
toArray does not create a new Array:
scala> val foo = Array(1 , 2)
foo: Array[Int] = Array(1, 2)
scala> foo eq foo.toArray
res0: Boolean = trueThere was a problem hiding this comment.
@felixmulder Did you intend to make a copy?
There was a problem hiding this comment.
Nope, I think this is a remnant from when the ReplDriver didn't take an array.
There was a problem hiding this comment.
Great.
Btw, I have just signed the CLA.
There was a problem hiding this comment.
I have checked the classes involved in processing settings and have not found any mutation of the array, only conversion to list in CompilerCommand. Shall I defend the array from potential yet no existing side-effects by making a copy ? Seems like premature optimisation to me, but you decide :)
Taking into account that
settingsis of typeArray[String], there is no need to convertsettingsto array.