-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add -Ythrough-tasty to debug from TASTY compilation direct from sources #3786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
19c13f3
cf0212f
d525de3
d992f6c
4b1385e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
package dotty.tools | ||
package dotc | ||
package fromtasty | ||
|
||
import scala.util.control.NonFatal | ||
|
||
import dotty.tools.io.Directory | ||
|
||
import java.nio.file.{Files, Paths} | ||
|
||
object Debug { | ||
def main(args: Array[String]): Unit = { | ||
// Preload scala.util.control.NonFatal. Otherwise, when trying to catch a StackOverflowError, | ||
// we may try to load it but fail with another StackOverflowError and lose the original exception, | ||
// see <https://groups.google.com/forum/#!topic/scala-user/kte6nak-zPM>. | ||
val _ = NonFatal | ||
|
||
assert(!args.contains("-d")) | ||
|
||
val outPath = Paths.get("out") | ||
Directory(outPath).createDirectory() | ||
|
||
val tmpOut = Files.createTempDirectory(outPath.toAbsolutePath, "from-tasty-tmp") | ||
|
||
val fromSourcesOut = Files.createDirectory(tmpOut.resolve("from-source")) | ||
|
||
println(s"Compiling .scala") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since you pointed out to me that temporary directory are not deleted on exit, I would revert to you previous version: There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I will change it to |
||
val compilation1 = dotc.Main.process("-d" +: fromSourcesOut.toString +: args) | ||
|
||
if (compilation1.hasErrors) { | ||
println("Failed compilation from sources") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would remove this. If the compilation failed, the compiler already tells you "error found" There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It would not tell me which of the two compilation failed. |
||
sys.exit(1) | ||
} | ||
|
||
val fromTastyOut = Files.createDirectory(tmpOut.resolve("from-tasty")) | ||
|
||
val ext = "hasTasty" | ||
val classes = Directory(fromSourcesOut).walk.filter(x => x.isFile && x.extension == ext).map { x => | ||
val source = x.toString | ||
source.substring(fromSourcesOut.toString.length + 1, source.length - ext.length - 1).replace('/', '.') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe add a comment to explain what this does There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ok |
||
}.toList | ||
|
||
val fromTastyArgs = { | ||
"-from-tasty" :: | ||
"-d" :: fromTastyOut.toString :: | ||
insertClasspathInArgs(args.filterNot(_.endsWith(".scala")).toList, fromSourcesOut.toString) ::: | ||
classes | ||
} | ||
|
||
println(s"Compiling TASTY") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "Compiling from TASTY..."? Also the |
||
val compilation2 = dotc.Main.process(fromTastyArgs.toArray) | ||
|
||
if (compilation2.hasErrors) { | ||
println("Failed compilation from TASTY") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would remove this. If the compilation failed, the compiler already tells you "error found" There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The issue is that the errors will not tell you which of the compilation failed. I prefer to be explicit, so anyone that uses the tool know exactly what is happening. |
||
println("Compilation input: " + fromSourcesOut) | ||
sys.exit(1) | ||
} | ||
|
||
Directory(tmpOut).deleteRecursively() | ||
} | ||
|
||
private def insertClasspathInArgs(args: List[String], cp: String): List[String] = { | ||
val (beforeCp, fromCp) = args.span(_ != "-classpath") | ||
val classpath = fromCp.drop(1).headOption.fold(cp)(_ + ":" + cp) | ||
"-classpath" :: classpath :: beforeCp ::: fromCp.drop(2) | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this tool support the
-d
option? I think it would nice. Maybe use it as the base director instead ofout
if specifiedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If someone needs that feature in the future, he can implement it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would actually be unsafe. For the test to be reproducible the output directory needs to be empty.