Skip to content

Improve tasty definitions #4302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Improve tasty definitions #4302

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0173347
Fix definition type trees
nicolasstucki Apr 12, 2018
ff09679
Simplify definition of tasty booleans
nicolasstucki Apr 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions tests/pos/tasty/definitions.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,15 +50,15 @@ object definitions {

// ------ Definitions ---------------------------------

trait Definition extends Statement {
trait Definition extends Statement {
def name: Name
def owner: Definition = ???
}

case class ValDef(name: TermName, tpt: Term, rhs: Option[Term], mods: List[Modifier]) extends Definition
case class ValDef(name: TermName, tpt: TypeTree, rhs: Option[Term], mods: List[Modifier]) extends Definition
case class DefDef(name: TermName, typeParams: List[TypeDef], paramss: List[List[ValDef]],
returnTpt: Term, rhs: Option[Term], mods: List[Modifier]) extends Definition
case class TypeDef(name: TypeName, rhs: Term, mods: List[Modifier]) extends Definition
returnTpt: TypeTree, rhs: Option[Term], mods: List[Modifier]) extends Definition
case class TypeDef(name: TypeName, rhs: TypeTree, mods: List[Modifier]) extends Definition
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

case class ClassDef(name: TypeName, constructor: DefDef, parents: List[Term],
self: Option[ValDef], body: List[Statement], mods: List[Modifier]) extends Definition

Expand Down Expand Up @@ -197,6 +197,7 @@ object definitions {
object ErasedImplicitMethodType extends SpecializedMethodTypeCompanion

case class TypeBounds(loBound: Type, hiBound: Type)

case class NoPrefix()
object NoPrefix extends NoPrefix
}
Expand Down Expand Up @@ -231,9 +232,8 @@ object definitions {

enum Constant(val value: Any) {
case Unit extends Constant(())
case False extends Constant(false)
case True extends Constant(true)
case Null extends Constant(null)
case Boolean(v: scala.Boolean) extends Constant(v)
case Byte(v: scala.Byte) extends Constant(v)
case Short(v: scala.Short) extends Constant(v)
case Char(v: scala.Char) extends Constant(v)
Expand Down