Fix #4590: Reintroduce old inline accessor scheme as a fallback #4634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out things are not so simple. Some inline accessors cannot be handled in the same way as protected accessors because we cannot always place an accessor method next to the accessed symbol. We solve this by using an adapted version of the old inline accessor scheme as a fallback.
smarter
reviewed
Jun 9, 2018
| * `TestPassing` class in test `run/inline/inlines_1`: | ||
| * | ||
| * class C[T](x: T) { | ||
| * private[inlines] def next[U](y: U): (T, U) = (x, y) |
There was a problem hiding this comment.
Is all of this code needed just to create accessors to private-qualified methods? Since they'll end up being public method in the bytecode anyway, maybe we can just relax the accessibility rules inside inlined trees for them.
There was a problem hiding this comment.
It could also be package private methods in Java classes. Also, in the future we would like to avoid widening protected to public, so it would apply to Scala-defined classes as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out things are not so simple. Some inline accessors cannot be handled
in the same way as protected accessors because we cannot always place an accessor
method next to the accessed symbol.
We solve this by using an adapted version of the old inline accessor scheme as a fallback.