Skip to content

Harden IDE #4635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2018
Merged

Harden IDE #4635

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion language-server/src/dotty/tools/languageserver/DottyLanguageServer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,9 @@ class DottyLanguageServer extends LanguageServer
if (sym == NoSymbol) Nil.asJava
else {
val refs = Interactive.namedTrees(uriTrees, Include.references | Include.overriding, sym)
refs.map(ref => new DocumentHighlight(range(ref.namePos), DocumentHighlightKind.Read)).asJava
( for (ref <- refs if ref.namePos.exists)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've hit on the same issue when doing syntax highlighting. The problem is that namePos is nonsensical for some special trees. For example trees named <init> or <error>. This probably doesn't fix the problem because you still get a position that exists but is wrong. I tried to fix it in #4548, but that's not the correct fix. namePos should probably return NoPosition for "synthetic" names. But I don't think we have such think as "synthetic" names.

yield new DocumentHighlight(range(ref.namePos), DocumentHighlightKind.Read)
).asJava
}
}

Expand Down