Skip to content

Fix #476, restoreScopes should maintain companion links #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 20, 2015
Merged

Fix #476, restoreScopes should maintain companion links #478

merged 7 commits into from
Apr 20, 2015

Conversation

DarkDimius
Copy link
Contributor

No description provided.

@DarkDimius
Copy link
Contributor Author

@smarter please review.

@smarter
Copy link
Member

smarter commented Apr 15, 2015

Otherwise, LGTM.

@DarkDimius
Copy link
Contributor Author

additional checking in Ycheck somehow triggered StackOverflows in ExtensionMethods, due to forcing to much. Disabling them for now

@DarkDimius DarkDimius force-pushed the fix-restoreScopes branch 3 times, most recently from 4de0dd7 to 4efca0f Compare April 16, 2015 16:32
@smarter
Copy link
Member

smarter commented Apr 16, 2015

Was the build failure transient or is something still wrong?

@DarkDimius
Copy link
Contributor Author

With your proposed change 4de0dd7 the failure is persistent.
4efca0f seems stable.
For now, I need to get stuff done to prepare for run tests working, as partest is soon-to-be-merged.

@smarter
Copy link
Member

smarter commented Apr 16, 2015

I think withMode is actually wrong, shouldn't it be addMode ?

@DarkDimius
Copy link
Contributor Author

It would be if I would use created context to type the tree, as other modes influence type checking.
But as I use it only for symbol queries, I guess both are correct.

DarkDimius added a commit that referenced this pull request Apr 20, 2015
@DarkDimius
Merge pull request #478 from dotty-staging/fix-restoreScopes
c3844e5 
Fix #476, restoreScopes should maintain companion links
@DarkDimius DarkDimius merged commit c3844e5 into scala:master Apr 20, 2015
@allanrenucci allanrenucci deleted the fix-restoreScopes branch December 14, 2017 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DarkDimius @smarter