WIP #4721 try improving errors #4970
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We will get some other error when checking bounds in PostTyper, unless we get a failure in Typer which might produce questionable errors. Having a warning here might be better than nothing. ```scala -- Warning: tests/neg/i4721.scala:2:39 ----------------------------------------- 2 | def main(args: Array[String]):Unit = m(1) // error | ^ | Unsatisfiable type parameter constraints in polymorphic application -- [E007] Type Mismatch Error: tests/neg/i4721.scala:2:41 ---------------------- 2 | def main(args: Array[String]):Unit = m(1) // error | ^ | found: Int(1) | required: String | one warning found one error found ```
Blaisorblade
force-pushed
the
4721-improve-errors
branch
from
4347c29 to
0fd6077
Compare
|
@Blaisorblade Inactive for almost 5 months. Can you either finish the PR or close it and re-assign the issue to someone else? Thanks |
|
After discussion, assigned to @AleksanderBG as he's working in the area. |
|
@abgruszecki what is the status on this PR? Should we close it? |
|
I think it can be safely closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a type argument violates its bounds, we give the same errors whether the argument is specified by the user or inferred by the compiler. This PR is an (incomplete) attempt to detect and fix that. However, I failed to distinguish reliably inferred and synthesized type arguments, even following #4946 (comment)
This PR builds on #4946 to try improving the resulting error output. Sadly, the position of inferred arguments fails both
isSyntheticandisZeroExtent(arg.pos [53..54], false).