TypeAssigner: fix return type of clone() for arrays #501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would add a comment saying why |
|
Otherwise LGTM |
|
I added a comment in the code, feel free to merge if you think it's OK. |
|
Non-ansi chars present in comment: |
Given the following code: val x: Array[String] = new Array[String](1) x(0) = "foo" println(x.clone().apply(0)) Before this commit, the last line was rewritten in Erasure to: println(x.clone().[]apply(0)) This is incorrect: clone() returns an Object, so a cast is necessary, this resulted in the following failure at runtime: java.lang.VerifyError: Bad type on operand stack in aaload After this commit, the last line is rewritten in Erasure to: println(x.clone().asInstanceOf[String[]].[]apply(0)) This corresponds to adding a "checkcast" instruction in the generated bytecode, and is enough to fix the runtime error.
|
Whoops, fixed |
DarkDimius
added a commit
that referenced
this pull request
Apr 28, 2015
TypeAssigner: fix return type of clone() for arrays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the following code:
Before this commit, the last line was rewritten in Erasure to:
println(x.clone().[]apply(0))This is incorrect: clone() returns an Object, so a cast is necessary,
this resulted in the following failure at runtime:
After this commit, the last line is rewritten in Erasure to:
This corresponds to adding a "checkcast" instruction in the generated
bytecode, and is enough to fix the runtime error.
Review by @odersky .