Pickling modularization reorg #520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pickling package got rather large and confusing with three separate tasks that each had their own conventions: read JVM classfiles, read Scala2 pickle info, read Tasty. The classes for each task are now in separate packages.
| @@ -27,7 +27,7 @@ trait TreeInfo[T >: Untyped <: Type] { self: Trees.Instance[T] => | |||
| /** Does tree contain an initialization part when seen as a member of a class or trait? | |||
| */ | |||
| def isNoInitMember(tree: Tree): Boolean = unsplice(tree) match { | |||
| case EmptyTree | Import(_, _) | TypeDef(_, _) => true | |||
| case EmptyTree | Import(_, _) | TypeDef(_, _) | DefDef(_, _, _, _, _) => true | |||
There was a problem hiding this comment.
This seems unrelated to this PR.
|
Otherwise LGTM |
|
Yes, that should have been part of some other pull request. I believe the On Sat, May 2, 2015 at 9:56 PM, Dmitry Petrashko [email protected]
Martin Odersky |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pickling package got rather large and confusing with three
separate tasks that each had their own conventions: read JVM classfiles,
read Scala2 pickle info, read and write Tasty. The classes for each task are now in
separate packages.