Skip to content

Decompiler Syntax Highlighting #5231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 12, 2018
Merged

Conversation

tuvior
Copy link

@tuvior tuvior commented Oct 10, 2018

Added support for syntax highlighting in decompiler console output.
Colors are currently defined in SyntaxHighlightUtils and should be kept in sync with other places were colors are currently defined.

Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Commit Messages

We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).

Please stick to these guidelines for commit messages:

  1. Separate subject from body with a blank line
  2. When fixing an issue, start your commit message with Fix #<ISSUE-NBR>:
  3. Limit the subject line to 72 characters
  4. Capitalize the subject line
  5. Do not end the subject line with a period
  6. Use the imperative mood in the subject line ("Add" instead of "Added")
  7. Wrap the body at 80 characters
  8. Use the body to explain what and why vs. how

adapted from https://chris.beams.io/posts/git-commit

Have an awesome day! ☀️

@nicolasstucki nicolasstucki self-assigned this Oct 10, 2018
@nicolasstucki
Copy link
Contributor

Passing the withColor everywhere is too much overhead. I will add a simple way to access the settings from the Tasty instance.

@tuvior
Copy link
Author

tuvior commented Oct 10, 2018

That seems ideal, I initially tried going with that but there didn't seem to be a way to access the settings from Tasty yet.

@nicolasstucki nicolasstucki self-requested a review October 10, 2018 15:39
@nicolasstucki
Copy link
Contributor

@tuvior #5235 will help you to not have to pass the withColor argument everywhere.

@tuvior
Copy link
Author

tuvior commented Oct 10, 2018

Great, I'll incorporate it into the feature asap.

@tuvior tuvior force-pushed the decompiler-colors branch from e9ba13d to ef5c15c Compare October 10, 2018 17:16
@tuvior tuvior force-pushed the decompiler-colors branch from ef5c15c to d448810 Compare October 11, 2018 13:33
@nicolasstucki
Copy link
Contributor

@tuvior some other things broke with our previous fix, 1625b93 contains the proper fix. Cherry pick that commit and add it to this PR.

@nicolasstucki nicolasstucki merged commit 7e5f0a2 into scala:master Oct 12, 2018
@tuvior tuvior deleted the decompiler-colors branch October 17, 2018 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants