Skip to content

Fix #522. #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 3, 2015
Merged

Fix #522. #526

merged 2 commits into from
May 3, 2015

Conversation

odersky
Copy link
Contributor

@odersky odersky commented May 3, 2015

We were missing a substitution in full parameterization. Embarraingly, this
made even the example in the doc comment of fullyParameterizedDef fail.

Review by @smarter

We were missing a substitution in full parameterization. Embarraingly, this
made even the example in the doc comment of `fullyParameterizedDef` fail.
class Foo[+A <: AnyRef](val xs: List[A]) extends AnyVal {
def baz[B >: A](x: B): List[B] = ???
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of adding these tests here, you should move tests/pending/pos/t6482.scala and tests/pending/pos/t7022.scala to tests/pos/.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, will do.

@smarter
Copy link
Member

smarter commented May 3, 2015

Otherwise, LGTM.

odersky added a commit that referenced this pull request May 3, 2015
@odersky odersky merged commit 2a85b43 into scala:master May 3, 2015
@allanrenucci allanrenucci deleted the fix/#522 branch December 14, 2017 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants