Fix #5284: Restore worksheet decorations #5289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
reviewed
Oct 18, 2018
vscode-dotty/src/worksheet.ts
Outdated
| /** A worksheet managed by vscode */ | ||
| class Worksheet implements Disposable { | ||
|
|
||
| /** The version of this document the last time it was run */ | ||
| private runVersion: number = 0 |
There was a problem hiding this comment.
Maybe use -1 since 0 could be a valid version ?
When switching tabs, VSCode discards the text decorations that were added by worksheet evaluation. We now keep them in memory so that they can be added again when coming back to the worksheet.
smarter
approved these changes
Oct 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When switching tabs, VSCode discards the text decorations that were
added by worksheet evaluation. We now keep them in memory so that they
can be added again when coming back to the worksheet.