Fix #5486: Constant-fold types in TypeAssigner #5506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
To be consistent we also need to do it in TreeUnpickler and TypedTreeCopier because they don't use TypeAssigner for Select nodes. The main reason for this change is that it ensures that the pickled and unpickled trees have the same constant types, but it also means that inlined trees can get more precise types as witnessed by the added inline-constfold.scala test
smarter
force-pushed
the
fix-constfold
branch
from
5eb9f49 to
47ebafe
Compare
|
test performance please |
|
performance test scheduled: 2 job(s) in queue, 1 running. |
1 similar comment
|
performance test scheduled: 2 job(s) in queue, 1 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/5506/ to see the changes. Benchmarks is based on merging with master (9a9aa31) |
odersky
approved these changes
Nov 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be consistent we also need to do it in TreeUnpickler and
TypedTreeCopier because they don't use TypeAssigner for Select nodes.
The main reason for this change is that it ensures that the pickled and
unpickled trees have the same constant types, but it also means that
inlined trees can get more precise types as witnessed by the added
inline-constfold.scala test