-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Propagate dependencies through implicit parameters #5601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
trait Foo[In] { type Out } | ||
|
||
object Test { | ||
def fooInt: Foo[Int] { type Out = String } = ??? | ||
implicit def str: String = ??? | ||
|
||
def test1[A](f1: Foo[A])(implicit f2: f1.Out) = ??? | ||
def test2[A](implicit f1: Foo[A], f2: f1.Out) = ??? | ||
|
||
test1(fooInt) // OK | ||
test2 // error | ||
} | ||
|
||
object Test2 { | ||
implicit def fooInt: Foo[Int] { type Out = String } = ??? | ||
implicit def fooString: Foo[String] { type Out = Boolean } = ??? | ||
implicit def fooBoolean: Foo[Boolean] { type Out = Double } = ??? | ||
|
||
def test3[A](f1: Foo[A], f2: Foo[f1.Out])(implicit f3: Foo[f2.Out]): f3.Out = ??? | ||
def test4[A](implicit f1: Foo[A], f2: Foo[f1.Out], f3: Foo[f2.Out]): f3.Out = ??? | ||
|
||
val t3 = test3(fooInt, fooString) | ||
t3: Double | ||
val t4 = test4 // error | ||
t4: Double | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
trait Foo[In] { type Out } | ||
|
||
object Test { | ||
implicit def fooInt: Foo[Int] { type Out = String } = ??? | ||
implicit def str: String = ??? | ||
|
||
def test1[A](f1: Foo[A])(implicit f2: f1.Out) = ??? | ||
def test2[A](implicit f1: Foo[A], f2: f1.Out) = ??? | ||
|
||
test1(fooInt) // OK | ||
test2 // OK | ||
} | ||
|
||
object Test2 { | ||
implicit def fooInt: Foo[Int] { type Out = String } = ??? | ||
implicit def fooString: Foo[String] { type Out = Boolean } = ??? | ||
implicit def fooBoolean: Foo[Boolean] { type Out = Double } = ??? | ||
|
||
def test3[A](f1: Foo[A], f2: Foo[f1.Out])(implicit f3: Foo[f2.Out]): f3.Out = ??? | ||
def test4[A](implicit f1: Foo[A], f2: Foo[f1.Out], f3: Foo[f2.Out]): f3.Out = ??? | ||
|
||
val t3 = test3(fooInt, fooString) | ||
t3: Double | ||
val t4 = test4[Int] | ||
t4: Double | ||
} | ||
|
||
object Test3 { | ||
def fooInt: Foo[Int] { type Out = String } = ??? | ||
implicit def str: String = ??? | ||
|
||
def test5[A](implicit f1: Foo[A] = fooInt, f2: f1.Out) = f2 | ||
|
||
val t5 = test5 | ||
t5: String | ||
} | ||
|
||
object Test4 { | ||
implicit def fooInt: Foo[Int] { type Out = String } = ??? | ||
def str: String = ??? | ||
|
||
def test6[A](implicit f1: Foo[A], f2: f1.Out = str) = f2 | ||
|
||
val t6 = test6 | ||
t6: String | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think
arg.tpe.exists
can occur here unlikeaddTyped
, but we should checkarg.tpe.isError
since in case of implicit failure, the type will be an instance ofSearchFailureType
which is a subtype ofErrorType
:I also suggest adding some negative test cases that exercises this code path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do need
exists
here. Switching to!arg.tpe.isError
results in an assertion for a non-existent getter denotation.I'll add some negative test cases.