Make Modifiers not extend from Positioned #5668
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifiers was made a subclass of Positioned since it contains elements that are Positioned: source modifiers and annotations. That way, we got the navigation logic to get to the elements for free. However, a lot of modifiers are synthetic, and seems artificial to give these a position. With the addition of a source component to position the balance swings the other way. It now seems preferable to have Modifiers not extend Positions and to consider modifier as a as a separate case for navigation instead.
| @@ -2016,7 +2013,7 @@ object Parsers { | |||
| if (in.token == EQUALS) { in.nextToken(); expr() } | |||
| else EmptyTree | |||
| if (implicitOffset >= 0) { | |||
| mods = mods.withPos(mods.pos.union(Position(implicitOffset, implicitOffset))) | |||
| //mods = mods.withPos(mods.pos.union(Position(implicitOffset, implicitOffset))) | |||
There was a problem hiding this comment.
This should be removed
| if (in.token == OBJECT) | ||
| stats += objectDef(start, atPos(start, in.skipToken()) { Modifiers(Package) }) | ||
| if (in.token == OBJECT) { | ||
| in.nextToken() |
|
This is part of #5664, where I also addressed review comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifiers was made a subclass of Positioned since it contains elements that
are Positioned: source modifiers and annotations. That way, we got the navigation
logic to get to the elements for free. However, a lot of modifiers are synthetic,
and it seems artificial to give these a position. With the addition of a source
component to position the balance swings the other way. It now seems preferable
to have Modifiers not extend Positions and to consider Modifier as a as a separate
case for navigation instead.