-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Clarify blog post about extension methods #5771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, and thank you for opening this PR! 🎉
All contributors have signed the CLA, thank you! ❤️
Have an awesome day! ☀️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the revision. I see the value of putting the Ext Methods & Type Classes example, however I think the example is coming up to fast and could confuse a reader. This is just the announcement after all and extension methods is a general feature.
@biboudis |
My observation is just that we shouldn't jump from the simplest case of However since I am a strong advocate of examples I wouldn't contest to remove it. WDYT about putting a minor comment below the
|
I'm not sure to understand if you're proposing to remove the type class example or not.
Sure, why not. But I'm not sure why list "polymorphic". All methods can be polymorphic, it's not a special thing of extension methods. Or maybe you mean something else? Also, why make a difference between "visible under a simple name" and "enabled by bringing them in scope"? And why "enclosed in a trait" when they can be enclosed in anything (trait, class, object...)? Wouldn't it be simpler to just say "enabled when in scope"? |
Not anymore. Don't remove it. Just introduce it better with a small comment like the one above and we are good.
Sound's good, it is also different with other practices after all ;-) |
@biboudis done! Please, let's try to merge this sooner than later, while the blog post is still being read by people; because as it is now, it contains a pretty obscure and incomplete presentation of extension methods. |
Looks good. Merged. Obscurity wasn't intended (you rephrased sentences perfectly!), incompleteness was. |
No description provided.