Fix #5823: better erasure of bottom types #5926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the definition of lub so that:
- lub(C, {Null, Nothing}) = C if C is a reference type
- lub(C, {Null, Nothing}) = Object if C is a value type (as before)
This allows us to generate more efficient code, and it better
matches the user's expectations.
abeln
commented
Feb 14, 2019
| } | ||
| } | ||
| def erasedLub(tp1: Type, tp2: Type)(implicit ctx: Context): Type = { | ||
| // After erasure, C | {Null, Nothing} is just C, if C is a reference type. |
There was a problem hiding this comment.
The diff is misleading: I only added the check at the start, but since the pattern matching expressions is no longer at the top level the whole thing is highlighted.
odersky
approved these changes
Feb 15, 2019
ghost
removed
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the definition of lub so that:
This allows us to generate more efficient code, and it better
matches the user's expectations.