Add/simplify primitives #598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
force-pushed
the
add/simplify-primitives
branch
from
60c179d to
3594109
Compare
|
/rebuild |
1 similar comment
|
/rebuild |
| @@ -386,6 +386,9 @@ object SymDenotations { | |||
| /** Is symbol a primitive value class? */ | |||
| def isPrimitiveValueClass(implicit ctx: Context) = defn.ScalaValueClasses contains symbol | |||
|
|
|||
| /** Is symbol a primitive value class? */ | |||
| def isNumericValueClass(implicit ctx: Context) = defn.ScalaNumericValueClasses contains symbol | |||
There was a problem hiding this comment.
Neither name nor comment explains what this method does. Comment says nothing about class being numeric, and name of the method does not say anything about class being primitive. Methods tests for both of those.
|
Otherwise LGTM. |
odersky
force-pushed
the
add/simplify-primitives
branch
from
3594109 to
f5a70a2
Compare
|
Added comments and rebased to master. |
Harmonization is Dotty's alternative to Scala 2's notion of weak conformance. It is less powerful but also less entangled with the core type system. The idea is that in some specific contexts trees that all have primitive numeric types will be converted as necessary so that they all have the same numeric type. These tree sets are: - the two branches of an if - the alternatives of a match - the body together with the catch blocks of a try - the arguments of a vararg parameter Examples are in the test file, harmonize.scala.
odersky
force-pushed
the
add/simplify-primitives
branch
from
f5a70a2 to
d07d669
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Harmonize trees with numeric types to have the same type. Dotty's alternative to Scala 2's concept of weak conformance. Review by @DarkDimius