Fix launchIDE in the Dotty build after the full bootstrap #6353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we compiled it with the reference compiler. Both work, but using the bootstrapped compiler means we can catch potential regressions before we update the reference compiler to a new version.
- Make sure that when the `excludeFromIDE` sbt-dotty plugin setting is on in a project, we don't try to run any non-trivial task in that project. - Add all non-bootstrapped projects to `excludeFromIDE`, we always want to run the IDE with a bootstrapped compiler in the Dotty build. We did not need to do this before the full bootstrap because the non-bootstrapped projects were automatically excluded since they were Scala 2 projects.
nicolasstucki
approved these changes
Apr 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.