Evaluate annotations in Namer #641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review by @xeno-by |
|
@xeno-by I would like to do it even earlier, during enter, but that currently does not pass the test suite. |
|
I will try take a look tomorrow. Would that work for you? |
|
@xeno-by Sure. |
|
So, if I'm getting this right, this pull requests makes typechecking annotation types eager upon completion of the underlying member, but annotation arguments still remain lazy? |
Annotations were evaluated in Typer, which meant that they could be used only after type checking was complete (or compilation order dependencies would be introduced). This commit makes annotations be installed as part of completion in Namer. However, annotations are now lazy so as to avoid cyclic references. This is completely analogous to the scheme in unpickler and ClassfileParser.
odersky
force-pushed
the
change/early-annotations
branch
from
7196517 to
d59ab5d
Compare
|
I tried to follow @olhotak's suggestion but that caused errors, unfortunately. A more conservative commit will follow. |
odersky
force-pushed
the
change/early-annotations
branch
from
d59ab5d to
abbc707
Compare
|
@olhotak Anything further, or can we merge this? |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annotations were evaluated in Typer, which meant that they could be used only after type checking was
complete (or compilation order dependencies would be introduced). This commit makes annotations be
installed as part of completion in Namer. However, annotations are now lazy so as to avoid cyclic
references. This is completely analogous to the scheme in unpickler and ClassfileParser.