Replace CompilationTest + by aggregateTests #6427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is not the first time that we have missed a |
nicolasstucki
force-pushed
the
make-compilation-test-framework-more-resiliant
branch
from
08d2547 to
43d3ada
Compare
The motivation is to avoid bugs like the one fixed in scala#6423 to ever happen. In the previous scheme a missing `+` results in tests not being executed, while now a missing comma will be a compilation error.
nicolasstucki
force-pushed
the
make-compilation-test-framework-more-resiliant
branch
from
43d3ada to
38cf210
Compare
Merged
anatoliykmetyuk
approved these changes
May 3, 2019
There was a problem hiding this comment.
It would be nice to move the runtime exceptions to compile time, since this info is available on compile time. In the context of time-consuming test runs, it is better to catch these errors sooner. However such an encoding requires a lot of work. Nice that the concurrency is now improved!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation is to avoid bugs like the one fixed in #6423 to ever happen.
In the previous scheme a missing
+results in tests not being executed,while now a missing comma will be a compilation error.