Add Support of Parsing Annotations without Arguments to Java Parser #6893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
Jul 19, 2019
|
@smarter Could you please take a look? |
|
Will do. I added you as a contributor to dotty so you can assign people to PRs etc. |
smarter
requested changes
Oct 21, 2019
smarter
reviewed
Oct 21, 2019
smarter
reviewed
Oct 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support of parsing simple annotations in Java files which don't have arguments.
This PR is similar to #6731. For the explicit-nulls project, we want to read NotNull annotations of Java methods to generate better types. With this change, dotc can read simple annotations of methods in Java files.
Since all the NotNull annotations we are interested in does not require arguments, all the annotations with arguments are ignored.
This PR should not break any other functionalities.