Skip to content

Use Conversion[T, Expr[T]] for autolift #6977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/docs/reference/metaprogramming/macros.md
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ That is, the `showExpr` method converts its `Expr` argument to a string (`code`)
the result back to an `Expr[String]` using the `toExpr` method.

**Note**: the `toExpr` extension method can be ommited by importing an implicit
conversion with `import scala.quoted.autolift._`. The programmer is able to
conversion with `import given scala.quoted.autolift._`. The programmer is able to
declutter slightly the code at the cost of readable _phase distinction_ between
stages.

Expand Down
2 changes: 1 addition & 1 deletion library/src/scala/quoted/package.scala
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ package object quoted {
private object NoResult

object autolift {
implicit def autoToExpr[T: Liftable](x: T) given QuoteContext: Expr[T] = x.toExpr
given autoToExpr[T] as Conversion[T, Expr[T]] given Liftable[T], QuoteContext = _.toExpr
}

implicit object ExprOps {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._

object Macros {

Expand Down
2 changes: 1 addition & 1 deletion tests/disabled/run/xml-interpolation-3/XmlQuote_1.scala
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import scala.quoted._
import scala.tasty.Tasty
import scala.quoted.autolift._
import given scala.quoted.autolift._

import scala.language.implicitConversions

Expand Down
2 changes: 1 addition & 1 deletion tests/neg-macros/i6432/Macro_1.scala
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._
import scala.quoted.matching._

object Macro {
Expand Down
2 changes: 1 addition & 1 deletion tests/neg-macros/i6432b/Macro_1.scala
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._
import scala.quoted.matching._

object Macro {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._

object E {

Expand Down
2 changes: 1 addition & 1 deletion tests/neg-macros/inline-tuples-1/Macro_1.scala
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._

object Macros {
def tup1(tup: Tuple1[Int]) given QuoteContext: Expr[Int] = tup.productIterator.map(_.asInstanceOf[Int]).sum
Expand Down
2 changes: 1 addition & 1 deletion tests/neg-macros/quote-interpolator-core-old.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._

// This test checks the correct interpretation of the inlined value class

Expand Down
2 changes: 1 addition & 1 deletion tests/neg-macros/quote-macro-splice.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._

object Test {

Expand Down
2 changes: 1 addition & 1 deletion tests/neg-macros/splice-in-top-level-splice-1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._

object Foo {
inline def foo(): Int = ${bar(${x})} // error
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._

object Macros {

Expand Down
2 changes: 1 addition & 1 deletion tests/pending/run/tasty-comments/quoted_1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._


object Macros {
Expand Down
2 changes: 1 addition & 1 deletion tests/pos-macros/i6803b/Macro_1.scala
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ package blah

import scala.language.implicitConversions
import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._

object AsObject {
final class LineNo(val lineNo: Int)
Expand Down
2 changes: 1 addition & 1 deletion tests/pos-macros/quote-nested-object/Macro_1.scala
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._

object Macro {

Expand Down
2 changes: 1 addition & 1 deletion tests/pos-with-compiler/quote-0.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._

object Macros {

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._

object Foo {

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._

object Foo {

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._

object Macros {

Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/f-interpolation-1/FQuote_1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._

import scala.language.implicitConversions

Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/f-interpolator-neg/Macros_1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._
import scala.quoted.matching._

import scala.language.implicitConversions
Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/i4734/Macro_1.scala
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import scala.annotation.tailrec
import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._

object Macros {
inline def unrolledForeach(seq: IndexedSeq[Int], f: => Int => Unit, inline unrollSize: Int): Unit = // or f: Int => Unit
Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/i4735/Macro_1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.annotation.tailrec
import scala.quoted.autolift._
import given scala.quoted.autolift._

import scala.quoted._

Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/i5119/Macro_1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._

object Macro {
class StringContextOps(sc: => StringContext) {
Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/i5119b/Macro_1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._


object Macro {
Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/i5188a/Macro_1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._

object Lib {
inline def sum(inline args: Int*): Int = ${ impl(args: _*) }
Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/i6518/Macro_1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._

object Macros {

Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/inferred-repeated-result/test_1.scala
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
object Macros {
import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._

inline def go[T](t: => T) = ${ impl('t) }
def impl[T](expr: Expr[T]) given (qctx: QuoteContext): Expr[Unit] = {
Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/inline-option/Macro_1.scala
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._

object Macros {

Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/inline-tuples-1/Macro_1.scala
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._

object Macros {
def tup1(tup: Tuple1[Int]) given QuoteContext: Expr[Int] = tup.productIterator.map(_.asInstanceOf[Int]).sum
Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/inline-tuples-2/Macro_1.scala
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._

object Macros {

Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/inline-varargs-1/Macro_1.scala
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._

object Macros {
def sum(nums: Int*) given QuoteContext: Expr[Int] = nums.sum
Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/quote-force/quoted_1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._

case class Location(owners: List[String])

Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/quote-impure-by-name/quoted_1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._


class Index[K, Keys](val index: String) extends AnyVal {
Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/quote-inline-function/quoted_1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._

object Macros {

Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/quote-matching-optimize-1/Macro_1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._

object Macro {

Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/quote-matching-optimize-2/Macro_1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._

import scala.tasty.Reflection

Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/quote-matching-optimize-3/Macro_1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._

import scala.tasty.Reflection

Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/quote-simple-macro/quoted_1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._

object Macros {
inline def foo(inline i: Int, dummy: Int, j: Int): Int = ${ bar(i, 'j) }
Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/quote-unrolled-foreach/quoted_1.scala
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import scala.annotation.tailrec
import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._

object Macro {

Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/tasty-argument-tree-1/quoted_1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._

object Macros {

Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/tasty-custom-show/quoted_1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._


object Macros {
Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/tasty-definitions-1/quoted_1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._

object Macros {

Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/tasty-eval/quoted_1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._

object Macros {

Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/tasty-extractors-1/quoted_1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._

object Macros {

Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/tasty-extractors-2/quoted_1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._

object Macros {

Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/tasty-extractors-3/quoted_1.scala
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import scala.quoted._

import scala.quoted.autolift._
import given scala.quoted.autolift._

object Macros {

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._

import scala.quoted.matching._

Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/tasty-extractors-types/quoted_1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._

object Macros {

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._

object SourceFiles {

Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/tasty-getfile/Macro_1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._


object SourceFiles {
Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/tasty-indexed-map/quoted_1.scala
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

import scala.quoted._
import scala.quoted.autolift._
import given scala.quoted.autolift._

class MyMap[Keys](private val underlying: Array[Int]) extends AnyVal {
def get[K <: String](implicit i: Index[K, Keys]): Int = underlying(i.index)
Expand Down
Loading