Skip to content

Remove scala.tasty.util.Chars #7178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2019
Merged

Remove scala.tasty.util.Chars #7178

merged 1 commit into from
Sep 6, 2019

Conversation

nicolasstucki
Copy link
Contributor

Now we should be using scala.internal.Chars

@nicolasstucki nicolasstucki self-assigned this Sep 6, 2019
@nicolasstucki
Remove scala.tasty.util.Chars
f58f097 
Now we should be using scala.internal.Chars
@nicolasstucki nicolasstucki force-pushed the remove-tasty-util-chars branch from 0047108 to f58f097 Compare September 6, 2019 12:04
@nicolasstucki nicolasstucki marked this pull request as ready for review September 6, 2019 13:16
@nicolasstucki
Copy link
Contributor Author

Now that we have 0.18.1 as reference compiler we can finally remove it.

liufengyun
liufengyun approved these changes Sep 6, 2019
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit 633696a into scala:master Sep 6, 2019
@nicolasstucki nicolasstucki deleted the remove-tasty-util-chars branch September 6, 2019 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasstucki @liufengyun