Skip to content

Use 0.19.0 as base version #7179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2019
Merged

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki nicolasstucki self-assigned this Sep 6, 2019
@smarter
Copy link
Member

smarter commented Sep 6, 2019

Blog post should also be updated:

Dotty is now using the standard library 2.13 instead of the previous 2.12.8. This fact is reflected in the patch version 1 in 0.18.1-RC1 which Dotty will be using from now on.

@nicolasstucki
Copy link
Contributor Author

The blog post does not mention 0.19.1, only 0.18.1 which is correct.

@anatoliykmetyuk
Copy link
Contributor

This fact is reflected in the patch version 1

This can be a problem

@nicolasstucki
Copy link
Contributor Author

But it is a patch of 0.18 not 0.19

@anatoliykmetyuk
Copy link
Contributor

This sentence is selling the wrong story. As if, in general, patch version 1 has a relationship with the standard library in use, and the users can expect this relationship to hold also for further versions.

@bishabosha
Copy link
Member

which Dotty will be using from now on.

This is the part that should change

@nicolasstucki
Copy link
Contributor Author

This sentence is selling the wrong story. As if, in general, patch version 1 has a relationship with the standard library in use, and the users can expect this relationship to hold also for further versions.

@anatoliykmetyuk could you fix the misleading blogpost of 0.18.1 in another PR.

@nicolasstucki
Copy link
Contributor Author

We should probably merge this one before #7190 is fixed to avoid publishing misleading nightlies.

@smarter smarter merged commit 32b845a into scala:master Sep 10, 2019
@smarter smarter deleted the fix-base-version branch September 10, 2019 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants